fix(server): don't delete offline files from disk when trash empties #14777
+289
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etnoy
force-pushed
the
fix/empty-offline-files
branch
from
44f240d to
91b3b6a
Compare
jrasm91
reviewed
Dec 18, 2024
etnoy
force-pushed
the
fix/empty-offline-files
branch
from
91b3b6a to
0cffb62
Compare
etnoy
force-pushed
the
fix/empty-offline-files
branch
from
0cffb62 to
1a6e9bc
Compare
etnoy
force-pushed
the
fix/empty-offline-files
branch
from
1a6e9bc to
e8c5fcf
Compare
zackpollard
reviewed
Dec 19, 2024
The logic still needs to be in the asset service since that's where the deletion is initiated. Ideally I feel like it could be in the trash service, but it isn't for the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, immich deletes files after 30 days that are excluded or outside of import paths, including original files.
This is not intended, if a new exclusion pattern is added or an import path is changed and one or more assets are removed due to it, we should not be deleting original files.
This bug is in my opinion quite serious and could cause data loss.
I can't find the original bug report (github? reddit?)
Edit: This might be it: https://www.reddit.com/r/immich/comments/1gu61r3/immich_tried_to_remove_my_external_libraries_file/
Also adds some e2e tests related to offline files